Page MenuHomeVyOS Platform
Create Task
Maniphest T3126

unsuppress-map doesn't work for BGP IPv4
Closed, ResolvedPublicBUG
Actions

Description

set protocols bgp 12345 neighbor 1.2.3.4 address-family ipv4-unicast unsuppress-map 'test'

Doesn't get configured into FRR. The problem is the configuration script /opt/vyatta/sbin/vyatta-bgp.pl. It is missing the following code:

'protocols bgp var neighbor var address-family ipv4-unicast unsuppress-map' => {
    set => 'router bgp #3 ; address-family ipv4 unicast ; neighbor #5 unsuppress-map #9',
    del => 'router bgp #3 ; address-family ipv4 unicast ; no neighbor #5 unsuppress-map #9',
},

It is still under the old configuration tree "protocols bgp var neighbor var unsuppress-map"

I already tested this fix and it is working. It would be nice if this would be implemented in the next release because it is a simple fix. This also seems to be affecting 1.3.

Details

Difficulty level
Easy (less than an hour)
Version
1.2.6
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

Robot82 created this task.Dec 13 2020, 9:42 AM
pasik added a subscriber: pasik.Dec 13 2020, 10:23 AM
Viacheslav claimed this task.Jan 24 2021, 3:18 PM
Viacheslav added a project: VyOS 1.3 Equuleus.
Viacheslav added a comment.Jan 24 2021, 3:36 PM

PR https://github.com/vyos/vyatta-cfg-quagga/pull/67

set protocols bgp 65001 neighbor 100.64.0.2 address-family ipv4-unicast unsuppress-map 'FOO'
set protocols bgp 65001 neighbor 100.64.0.2 remote-as '65001'

FRR

!
router bgp 65001
 neighbor 100.64.0.2 remote-as 65001
 !
 address-family ipv4 unicast
  neighbor 100.64.0.2 unsuppress-map FOO
 exit-address-family
!
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Jan 25 2021, 6:28 PM
c-po moved this task from Need Triage to VyOS 1.2.7 on the VyOS 1.2 Crux board.
c-po edited projects, added VyOS 1.2 Crux (VyOS 1.2.7); removed VyOS 1.2 Crux.
c-po moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.7) board.
c-po moved this task from Finished to Backlog on the VyOS 1.2 Crux (VyOS 1.2.7) board.
c-po moved this task from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.7) board.
Viacheslav closed this task as Resolved.Jan 29 2021, 12:28 PM
dmbaturin removed a project: VyOS 1.3 Equuleus.Sep 10 2021, 2:39 PM