Page MenuHomeVyOS Platform

dhcp-server: Multiple domain-search values are escaped incorrectly
Closed, ResolvedPublic

Description

Hi,

Commit https://github.com/vyos/vyos-1x/commit/84b7ade286e4022e62684237246cd04b9d37b5db seems to have introduced a regression regarding the domain-search option.

Previously, multiple values were expressed in dhcpd.conf like so:

domain-search "domain1", "domain2";

Now, it's

domain-search "domain1, domain2";

which seems to cause isc-dhcp-client to ignore the value.

Maybe this also affects other options, haven't checked so far.

Best regards
Robert

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)

Event Timeline

efficiosoft created this task.
efficiosoft created this object in space S1 VyOS Public.
c-po changed the task status from Open to In progress.Dec 6 2020, 10:46 AM
c-po claimed this task.

Thanks for the quick fix!

Best regards
Robert