Page MenuHomeVyOS Platform
Create Task
Maniphest T2972

PPPoE server rate limiter allows max 65535 kbps to be set
Closed, ResolvedPublicBUG
Actions

Description

Rate limiter of PPPoE session allows max 65535 kbps to be set,

I am getting an error when trying to set more that 65535 kbps on upload or download limit

Any plans to extend rate limiter over 65535 kbps

Details

Difficulty level
Easy (less than an hour)
Version
vyos-1.3-rolling-202010100146
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)

Event Timeline

WhoIsHE created this task.Oct 11 2020, 2:28 PM
c-po renamed this task from Rate limiter of PPPoE session allows max 65535 kbps to be set to PPPoE server rate limiter allows max 65535 kbps to be set.Oct 11 2020, 4:29 PM
c-po assigned this task to Dmitry.
c-po triaged this task as Normal priority.
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
c-po added a subscriber: c-po.

@Dmitry is this a limitation of Accel-PPP or can we increase the limits on the CLI?

https://github.com/vyos/vyos-1x/blob/current/interface-definitions/include/accel-auth-local-users.xml.i#L29-L51

Dmitry added a comment.Oct 11 2020, 5:09 PM

@c-po , it looks like the wrong CLI definition, we can increase the limit in XML.

Dmitry added a comment.Oct 13 2020, 9:53 AM

PR with increasing validator values https://github.com/vyos/vyos-1x/pull/566

Dmitry changed the task status from Open to In progress.Oct 13 2020, 10:54 AM
Dmitry added a project: VyOS 1.2 Crux (VyOS 1.2.7).
Dmitry added a comment.Oct 13 2020, 11:20 AM

PR for CRUX https://github.com/vyos/vyos-1x/pull/568

c-po changed the task status from In progress to Needs testing.Oct 14 2020, 4:56 AM
pasik added a subscriber: pasik.Oct 14 2020, 6:35 AM
Dmitry closed this task as Resolved.Oct 14 2020, 7:59 AM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Nov 23 2020, 3:26 PM
c-po moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.7) board.Jan 2 2021, 12:02 PM
dmbaturin removed a project: VyOS 1.3 Equuleus.Sep 10 2021, 2:40 PM