Maniphest T2959

PPPoE server has migrations scripts but the config version is not incrememnted
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	c-po
	Oct 4 2020, 11:15 AM

Tags

Referenced Files

None

Subscribers

Global Notifications

Description

In VyOS 1.2.6 the PPPoE server config version is still 0 (https://github.com/vyos/vyatta-cfg-system/tree/cae9145346b60ebd6251643a5ce0ceed2a0f2364/cfg-version)

But the migrator references version 1 https://github.com/vyos/vyos-1x/tree/94355927bfa21cda01e7db54060cf0292bbacd43/src/migration-scripts/pppoe-server

In addition the version was bumped once more

Details

Version: 1.2.6
Is it a breaking change?: Unspecified (possibly destroys the router)

Related Objects

Mentioned Here: T2829: PPPoE server: mppe setting is implemented as node instead of leafNode

Event Timeline

c-po created this task.Oct 4 2020, 11:15 AM

c-po claimed this task.Oct 4 2020, 11:18 AM

c-po updated the task description. (Show Details)

This also relates to https://phabricator.vyos.net/T2829#76815

c-po closed this task as Resolved.Oct 4 2020, 4:46 PM

pasik subscribed.Oct 4 2020, 5:32 PM

c-po moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.7) board.Oct 11 2020, 5:36 PM