When calling add system image and upgrading from any version and decide to not use the suggested image name but rather append -XX to the image name GNU sed gets totally confused and the system won't boot next time.
vyos@vyos:~$ add sys im http://172.16.10.30/vyos-1.2.6-amd64.iso
Trying to fetch ISO file from http://172.16.10.30/vyos-1.2.6-amd64.iso
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 409M 100 409M 0 0 46.2M 0 0:00:08 0:00:08 --:--:-- 46.7M
ISO download succeeded.
Checking for digital signature file...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 833 100 833 0 0 98k 0 --:--:-- --:--:-- --:--:-- 101k
Found it. Checking digital signature...
gpg: assuming signed data in `/var/tmp/install-image.2122/vyos-1.2.6-amd64.iso'
gpg: Signature made Fri 11 Sep 2020 11:49:32 AM CEST using RSA key ID A0FE6D7E
gpg: Good signature from "VyOS Maintainers (VyOS Release) <[email protected]>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the owner.
Primary key fingerprint: 0694 A923 0F51 39BF 834B A458 FD22 0285 A0FE 6D7E
Digital signature is valid.
Checking MD5 checksums of files on the ISO image...OK.
Done!
What would you like to name this image? [1.2.6]: 1.2.6-XX
OK. This image will be named: 1.2.6-XX
Installing "1.2.6-XX" image.
Copying new release files...
Would you like to save the current configuration
directory and config file? (Yes/No) [Yes]:
Copying current configuration...
Would you like to save the SSH host keys from your
current configuration? (Yes/No) [Yes]:
Copying SSH keys...
Running post-install script...
Setting up grub configuration...
sed: -e expression #1, char 39: unknown option to `s'
Done.
The more problematic side effect is that you can not delete the faulty installation, as it will remove your /config folder and on the next boot we no longer have /config
vyos@vyos:~$ delete system image The following image(s) can be deleted: 1: Old-non-image-installation (default boot) 2: 1.2.5 (running image) Select the image to delete: 1 Are you sure you want to delete the "Old-non-image-installation" image? (Yes/No) [No]: y Deleting the "Old-non-image-installation" image... Skipping /lib/live/mount/persistence/boot. Deleting /lib/live/mount/persistence/lost+found... Deleting /lib/live/mount/persistence/persistence.conf... Done The default image has been changed to the currently running image: 1.2.5