Page MenuHomeVyOS Platform
Create Task
Maniphest T2717

Wrong DHCP server pool size in statistics
Closed, ResolvedPublic
Actions

Description

Hi,

When running

show dhcp server statistics

the pool sizes seem to be not correct. This is due to the get_pool_size() function in src/op_mode/show_dhcp.py, which just subtracts a range's lower bound from its upper bound and uses the result as pool size. However, since according to the man page [0] both boundaries are inclusive, it should add +1 to the subtraction result:

The range statement gives the lowest and highest IP addresses in a range.

[0] https://linux.die.net/man/5/dhcpd.conf

I could file a PR if you like, already prepared it.

Best regards
Robert

Details

Difficulty level
Unknown (require assessment)
Version
1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

efficiosoft triaged this task as Normal priority.Jul 20 2020, 1:44 PM
efficiosoft created this task.
efficiosoft created this object in space S1 VyOS Public.
efficiosoft renamed this task from Fix DHCP pool size in statistics to Wrong DHCP server pool size in statistics.Jul 20 2020, 1:49 PM
jjakob added a subscriber: jjakob.Jul 20 2020, 2:10 PM

I could file a PR if you like, already prepared it.

Please do, that would be very welcome!

efficiosoft claimed this task.Jul 20 2020, 4:06 PM

Ok, done here.

As this is my first Phabricator experience, is there anything else I have to do?

pasik added a subscriber: pasik.Jul 20 2020, 6:40 PM
efficiosoft closed this task as Resolved.Jul 20 2020, 7:49 PM
c-po added projects: VyOS 1.4 Sagitta, VyOS 1.3 Equuleus, VyOS 1.2 Crux (VyOS 1.2.8).Jun 10 2021, 5:51 PM
c-po moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.8) board.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
dmbaturin removed projects: VyOS 1.3 Equuleus, VyOS 1.4 Sagitta.Sep 10 2021, 2:43 PM