Page MenuHomeVyOS Platform

Config entries with default values do not correctly show as changed
Closed, ResolvedPublicBUG

Description

E.g. system time-zone contains a "default: UTC" in the node.def.

vyos@vyos:~$ conf
[edit]
vyos@vyos# set system time-zone Etc/GMT        <-- Change time-zone
[edit]
vyos@vyos# show system time-zone 
>time-zone Etc/GMT                             <-- Shown as changed
[edit]
vyos@vyos# commit
[ system time-zone Etc/GMT ]
Restarting rsyslog (via systemctl): rsyslog.service.

[edit]
vyos@vyos# show system time-zone 
 time-zone Etc/GMT
[edit]
vyos@vyos# del system time-zone                <-- Change time-zone again
[edit]
vyos@vyos# show system time-zone               <-- Not shown as changed (BUG, expected to show changed to UTC)
[edit]
vyos@vyos# commit
[ system time-zone UTC ]
Restarting rsyslog (via systemctl): rsyslog.service.

Probably related, but less of a real issue. Could pass as a (mis-)feature..

vyos@vyos:~$ conf
[edit]
vyos@vyos# show system time-zone               <-- time-zone not present in config
[edit]
vyos@vyos# commit
No configuration changes to commit
[edit]
vyos@vyos# set system time-zone UTC            <-- this is no real change to the value
[edit]
vyos@vyos# show system time-zone 
 time-zone UTC                                 <-- shown as not changed, but output still different than before..
[edit]
vyos@vyos# commit                              <-- commit still thinks config is changed
[edit]
vyos@vyos# commit
No configuration changes to commit
[edit]

Details

Difficulty level
Hard (possibly days)
Version
1.2.1
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Unspecified (please specify)

Event Timeline

dmbaturin added a subscriber: dmbaturin.

This rabbit hole goes deep. It's not just a display issue, but the whole reason we cannot have rollbacks without reboots—there's no way to generate an inverse changeset "thanks" to this.

XML command definitions don't use this, so when the last of the old definitions are gone, this will be fixed.

Viacheslav changed Difficulty level from Unknown (require assessment) to Hard (possibly days).
Viacheslav set Is it a breaking change? to Unspecified (possibly destroys the router).
dmbaturin claimed this task.

There are no old-style CLI definitions anymore, and thus no default: tags either, so this shouldn't be an issue anymore.

dmbaturin renamed this task from Config entries with default values does not correctly show as changed to Config entries with default values do not correctly show as changed.Mar 12 2024, 6:37 PM
dmbaturin set Issue type to Unspecified (please specify).