Page MenuHomeVyOS Platform
Create Task
Maniphest T1294

Trying to delete 'system syslog' throws an exception/traceback
Closed, ResolvedPublic
Actions

Description

While trying to create a minimal config to reproduce an issue, I tried to delete system ntp|syslog. Removing the syslog config gives the following exception/traceback:

[edit]
vyos@vyos# delete system ntp 
[edit]
vyos@vyos# delete system syslog 
[edit]
vyos@vyos# commit
[ system syslog ]
Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/syslog.py", line 282, in <module>
    generate(c)
  File "/usr/libexec/vyos/conf_mode/syslog.py", line 228, in generate
    config_text = tmpl.render(c)
  File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 1003, in render
    vars = dict(*args, **kwargs)
TypeError: 'NoneType' object is not iterable

delete [ system syslog ] failed
Commit failed
[edit]
vyos@vyos#

Maybe the syslog configuration is not indeded to be removed but there could be some nicer warning/error about this

Details

Version
1.2.0-rolling+201903040337

Related Objects

Event Timeline

varesa created this task.Mar 11 2019, 7:40 PM
varesa triaged this task as Low priority.
varesa created this object in space S1 VyOS Public.
hagbard changed the task status from Open to In progress.Mar 11 2019, 9:41 PM
hagbard claimed this task.
hagbard added a comment.Mar 11 2019, 9:59 PM

journalctl needs systlsog since it's supposed to it's messages there, so the above commands won't stop rsyslog, but I'll fix the error for the cli.

hagbard mentioned this in rVYOSONEX906eb46b97e1: yslog] version bump for T1294.Mar 11 2019, 10:08 PM
hagbard mentioned this in rVYOSONEXdf6999ecf8dc: [rsyslog] Fixes: T1294 - Trying to delete 'system syslog' throws an exception.
hagbard changed the task status from In progress to Needs testing.Mar 11 2019, 10:16 PM

http://dev.packages.vyos.net/repositories/current/vyos/pool/main/v/vyos-1x/vyos-1x_1.3.0-14_all.deb or tonights rolling. systelog will still run and will log journalctl messages.

pasik subscribed.Mar 12 2019, 5:16 PM
hagbard closed this task as Resolved.Mar 12 2019, 8:22 PM
dmbaturin mentioned this in rVYOSONEX4d54708384bf: [rsyslog] Fixes: T1294 - Trying to delete 'system syslog' throws an exception.May 26 2019, 1:23 PM