diff --git a/changelogs/fragments/avoid_unsafe_conditions.yml b/changelogs/fragments/avoid_unsafe_conditions.yml new file mode 100644 index 0000000..693f01d --- /dev/null +++ b/changelogs/fragments/avoid_unsafe_conditions.yml @@ -0,0 +1,3 @@ +--- +trivial: + - avoid_unsafe_conditions - Avoid unsafe conditions in integration tests to resolve issues related to assertion unsafe conditions. diff --git a/tests/integration/targets/vyos_config/tests/cli/check_config.yaml b/tests/integration/targets/vyos_config/tests/cli/check_config.yaml index 2df0135..5e02854 100644 --- a/tests/integration/targets/vyos_config/tests/cli/check_config.yaml +++ b/tests/integration/targets/vyos_config/tests/cli/check_config.yaml @@ -1,57 +1,57 @@ --- - debug: msg="START cli/config_check.yaml on connection={{ ansible_connection }}" - name: setup- ensure interface is not present vyos.vyos.vyos_config: lines: delete interfaces loopback lo - name: setup- create interface register: result vyos.vyos.vyos_config: lines: - interfaces - interfaces loopback lo - interfaces loopback lo description test - name: Check that multiple duplicate lines collapse into a single commands assert: that: - - "{{ result.commands|length }} == 1" + - result.commands|length == 1 - name: Check that set is correctly prepended assert: that: - result.commands[0] == 'set interfaces loopback lo description test' - name: configure config_check config command register: result vyos.vyos.vyos_config: lines: delete interfaces loopback lo - assert: that: - result.changed == true - name: check config_check config command idempontent register: result vyos.vyos.vyos_config: lines: delete interfaces loopback lo - assert: that: - result.changed == false - name: check multiple line config filter is working register: result vyos.vyos.vyos_config: lines: - set system login user esa level admin - set system login user esa authentication encrypted-password '!abc!' - set system login user vyos level admin - set system login user vyos authentication encrypted-password 'abc' - assert: that: - - "{{ result.filtered|length }} == 2" + - result.filtered|length == 2 - debug: msg="END cli/config_check.yaml on connection={{ ansible_connection }}" diff --git a/tests/integration/targets/vyos_config/tests/redirection/cli/shortname.yaml b/tests/integration/targets/vyos_config/tests/redirection/cli/shortname.yaml index f397a27..e5bb8dd 100644 --- a/tests/integration/targets/vyos_config/tests/redirection/cli/shortname.yaml +++ b/tests/integration/targets/vyos_config/tests/redirection/cli/shortname.yaml @@ -1,99 +1,99 @@ --- - debug: msg="START cli/shortname.yaml on connection={{ ansible_connection }}" - name: setup- ensure interface is not present vyos.vyos.config: lines: delete interfaces loopback lo - name: setup- create interface register: result vyos.vyos.config: lines: - interfaces - interfaces loopback lo - interfaces loopback lo description test - name: Check that multiple duplicate lines collapse into a single commands assert: that: - - "{{ result.commands|length }} == 1" + - result.commands|length == 1 - name: Check that set is correctly prepended assert: that: - result.commands[0] == 'set interfaces loopback lo description test' - name: configure config_check config command register: result vyos.vyos.config: lines: delete interfaces loopback lo - assert: that: - result.changed == true - name: check config_check config command idempontent register: result vyos.vyos.config: lines: delete interfaces loopback lo - assert: that: - result.changed == false - name: check multiple line config filter is working register: result vyos.vyos.config: lines: - set system login user esa level admin - set system login user esa authentication encrypted-password '!abc!' - set system login user vyos level admin - set system login user vyos authentication encrypted-password 'abc' - assert: that: - - "{{ result.filtered|length }} == 2" + - result.filtered|length == 2 - name: Remove interface description and delete temp user vyos.vyos.config: &cleanup lines: - "delete interfaces ethernet eth0 description TEST-INTF" - "delete system login user test_user" - name: Use src with module alias register: result vyos.vyos.config: src: config.j2 - assert: that: - result.changed == true - '"set interfaces ethernet eth0 description TEST-INTF" in result.commands' - '"set system login user test_user" in result.commands' - name: "Restore hostname to {{ inventory_hostname }} and delete temp user" vyos.vyos.config: *cleanup - name: use module alias to take configuration backup register: result vyos.vyos.config: backup: true backup_options: filename: backup_with_alias.cfg dir_path: "{{ role_path }}/backup_test_dir/{{ inventory_hostname_short }}" - assert: that: - result.changed == true - name: check if the backup file-4 exist find: paths: "{{ role_path }}/backup_test_dir/{{ inventory_hostname_short }}/backup_with_alias.cfg" register: backup_file connection: local - assert: that: - backup_file.files is defined - debug: msg="END cli/shortname.yaml on connection={{ ansible_connection }}"