Page MenuHomeVyOS Platform
Feed Search

Jul 12 2023

jestabro committed rVYOSONEX38a8bcfc407f: config: T5330: add subclass ConfigDict to preserve merge data.
Jul 12 2023, 7:10 PM
jestabro committed rVYOSONEX4c4a2ddd4cc0: config: T5330: retain information of internal _dict_merge.
Jul 12 2023, 7:09 PM
jestabro closed T5347: Compare commit revision bug as Resolved.
Jul 12 2023, 2:34 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T5347: Compare commit revision bug: T5353: config-mgmt: normalize archive updates and commit log entries.
Jul 12 2023, 2:33 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T5353: config-mgmt: normalize archive updates and commit log entries: T5347: Compare commit revision bug.
Jul 12 2023, 2:33 PM · VyOS 1.5 Circinus, VyOS 1.4 Sagitta
jestabro triaged T5353: config-mgmt: normalize archive updates and commit log entries as Normal priority.
Jul 12 2023, 2:33 PM · VyOS 1.5 Circinus, VyOS 1.4 Sagitta
jestabro changed the status of T5006: Http api segfault with concurrent requests from Resolved to Unknown Status.

Bug introduced in 1.3.x with upgrade of FastAPI framework in:
https://vyos.dev/T5176

Jul 12 2023, 1:07 PM · VyOS 1.3 Equuleus (1.3.4), VyOS 1.4 Sagitta
jestabro changed the status of T5305: REST API configure operation should not be defined as async from Resolved to Unknown Status.

Yes; it was not evident in 1.3.x until the upgrade of the FastAPI framework for
https://vyos.dev/T5176
and will be backported.

Jul 12 2023, 1:05 PM · VyOS 1.3 Equuleus (1.3.4), VyOS 1.4 Sagitta

Jul 11 2023

jestabro committed rVYOSONEX01c47cf00572: config-mgmt: T5347: correct logrotate conf permissions on system update.
Jul 11 2023, 10:23 PM
jestabro claimed T5350: Confusing warning message when committing VRRP config.
Jul 11 2023, 10:04 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5347: Compare commit revision bug.

PR:
https://github.com/vyos/vyos-1x/pull/2086

Jul 11 2023, 5:50 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5347: Compare commit revision bug.

@zsdc thanks for the detailed explanation; @Viacheslav confirmed this is the case on update, and I will adopt your suggestion.

Jul 11 2023, 4:08 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T5319: Remove remaining workarounds for incorrect defaults: T5350: Confusing warning message when committing VRRP config.
Jul 11 2023, 1:51 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T5330: Keep track of source of config dict value when merging defaults: T5350: Confusing warning message when committing VRRP config.
Jul 11 2023, 1:51 PM · VyOS 1.4 Sagitta
jestabro added parent tasks for T5350: Confusing warning message when committing VRRP config: T5330: Keep track of source of config dict value when merging defaults, T5319: Remove remaining workarounds for incorrect defaults.
Jul 11 2023, 1:51 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5350: Confusing warning message when committing VRRP config.

Thanks, @dex, agreed that this is misleading: this will be refined once the PR
https://github.com/vyos/vyos-1x/pull/2079
is merged.

Jul 11 2023, 1:49 PM · VyOS 1.4 Sagitta

Jul 10 2023

jestabro claimed T5347: Compare commit revision bug.
Jul 10 2023, 6:18 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5347: Compare commit revision bug.

There are several issues mentioned in this task so far, and they will be separated out to respective tasks. Firstly, we will address an obvious bug in the implementation that misnumbers entries in the commit log compared to archived commit files ...

Jul 10 2023, 6:17 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5347: Compare commit revision bug.

As shared with @Viacheslav , I see the following on a 1.4 VM, built last week:

Jul 10 2023, 1:15 PM · VyOS 1.4 Sagitta
jestabro closed T5345: Error incorrectly raised in revised multi_to_list when tag node value name == tag node name as Resolved.
Jul 10 2023, 12:35 AM · VyOS 1.4 Sagitta

Jul 9 2023

jestabro committed rVYOSONEX91e94036bf80: xml: T5345: remove unneeded, incorrect check on paths.
Jul 9 2023, 10:55 PM
jestabro triaged T5345: Error incorrectly raised in revised multi_to_list when tag node value name == tag node name as Urgent! priority.
Jul 9 2023, 7:49 PM · VyOS 1.4 Sagitta

Jul 7 2023

jestabro added a comment to T5330: Keep track of source of config dict value when merging defaults.

PR:
https://github.com/vyos/vyos-1x/pull/2079

Jul 7 2023, 2:13 PM · VyOS 1.4 Sagitta

Jul 6 2023

jestabro committed rVYOSONEXaee16ab9ed2d: xml: T5218: add missing str.split() in defaults of multi node.
Jul 6 2023, 10:49 AM
jestabro committed rVYOSONEX7147c7c6a541: vyos.configdict: T5319: remove defaults workarounds in get_accel_dict.
Jul 6 2023, 10:49 AM
jestabro added a comment to T5330: Keep track of source of config dict value when merging defaults.

Implementation here:
https://github.com/vyos/vyos-1x/compare/current...jestabro:from-defaults

Jul 6 2023, 4:06 AM · VyOS 1.4 Sagitta

Jun 30 2023

jestabro added a subtask for T5228: Simplify get_config_dict and add argument with_defaults: T5330: Keep track of source of config dict value when merging defaults.
Jun 30 2023, 7:41 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T5330: Keep track of source of config dict value when merging defaults: T5228: Simplify get_config_dict and add argument with_defaults.
Jun 30 2023, 7:41 PM · VyOS 1.4 Sagitta
jestabro updated the task description for T5330: Keep track of source of config dict value when merging defaults.
Jun 30 2023, 7:40 PM · VyOS 1.4 Sagitta
jestabro triaged T5330: Keep track of source of config dict value when merging defaults as Normal priority.
Jun 30 2023, 7:30 PM · VyOS 1.4 Sagitta

Jun 29 2023

jestabro closed T5320: Add warning when entering config mode after a boot configuration error as Resolved.
Jun 29 2023, 4:20 PM · VyOS 1.4 Sagitta

Jun 28 2023

jestabro committed rVYOSONEX3d006d519ca9: T5320: warn on entering config mode if boot config errors present.
Jun 28 2023, 11:08 PM
jestabro committed rVYOSONEX186d05c3c792: T5320: check if unsaved commits are due to boot config error.
Jun 28 2023, 11:08 PM
jestabro added a comment to T5320: Add warning when entering config mode after a boot configuration error.

PR:
https://github.com/vyos/vyos-1x/pull/2060

Jun 28 2023, 4:54 PM · VyOS 1.4 Sagitta
jestabro triaged T5320: Add warning when entering config mode after a boot configuration error as Normal priority.
Jun 28 2023, 4:37 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T5319: Remove remaining workarounds for incorrect defaults: T5308: Remove workarounds for incorrect defaults in get_interface_dict.
Jun 28 2023, 3:17 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T5308: Remove workarounds for incorrect defaults in get_interface_dict: T5319: Remove remaining workarounds for incorrect defaults.
Jun 28 2023, 3:17 PM · VyOS 1.4 Sagitta
jestabro triaged T5319: Remove remaining workarounds for incorrect defaults as Normal priority.
Jun 28 2023, 3:17 PM · VyOS 1.4 Sagitta

Jun 27 2023

jestabro changed Issue type from improvement to internal on T5316: configtree: use a single pass of the diff algorithm.
Jun 27 2023, 1:38 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T5316: configtree: use a single pass of the diff algorithm: T5317: configtree: remove mutable references.
Jun 27 2023, 1:38 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T5317: configtree: remove mutable references: T5316: configtree: use a single pass of the diff algorithm.
Jun 27 2023, 1:37 PM · VyOS 1.4 Sagitta
jestabro triaged T5317: configtree: remove mutable references as Normal priority.
Jun 27 2023, 1:37 PM · VyOS 1.4 Sagitta
jestabro triaged T5316: configtree: use a single pass of the diff algorithm as Normal priority.
Jun 27 2023, 1:34 PM · VyOS 1.4 Sagitta
jestabro created T5316: configtree: use a single pass of the diff algorithm.
Jun 27 2023, 1:32 PM · VyOS 1.4 Sagitta

Jun 25 2023

jestabro committed rVYOSONEX800c3161bffc: tacacs: T141: check upper bound on dynamically allocated user accounts.
Jun 25 2023, 3:05 AM
jestabro committed rVYOSONEXb5346bc6cedd: smoketest: ssh_send_cmd should be a static method.
Jun 25 2023, 3:05 AM

Jun 24 2023

jestabro closed T5308: Remove workarounds for incorrect defaults in get_interface_dict, a subtask of T5228: Simplify get_config_dict and add argument with_defaults, as Resolved.
Jun 24 2023, 1:44 PM · VyOS 1.4 Sagitta
jestabro closed T5308: Remove workarounds for incorrect defaults in get_interface_dict as Resolved.
Jun 24 2023, 1:44 PM · VyOS 1.4 Sagitta
jestabro closed T5228: Simplify get_config_dict and add argument with_defaults, a subtask of T5218: Revise vyos xml lib for bug fixes and extensions, as Resolved.
Jun 24 2023, 1:43 PM · VyOS 1.4 Sagitta
jestabro closed T5228: Simplify get_config_dict and add argument with_defaults as Resolved.
Jun 24 2023, 1:43 PM · VyOS 1.4 Sagitta
jestabro committed rVYOSONEX1a18d5a59d14: config: T5228: simplify mangle_dict_keys.
Jun 24 2023, 1:08 PM
jestabro committed rVYOSONEXd57b7d327cef: config: T5228: use local _dict_merge to avoid circular import.
Jun 24 2023, 1:08 PM
jestabro committed rVYOSONEXf2f6b963b755: xml: T5218: fix error and simplify logic in recursive option.
Jun 24 2023, 1:08 PM
jestabro committed rVYOSONEXbf1fd02453b9: config: T5228: add arg with_defaults to get_config_dict.
Jun 24 2023, 1:08 PM
jestabro committed rVYOSONEXd19e7e5ce633: config: T5228: add get_config_defaults options to match get_config_dict.
Jun 24 2023, 1:08 PM
jestabro committed rVYOSONEX2a04aba09622: vyos.configdict: T5308: remove T2665 workarounds in get_interface_dict.
Jun 24 2023, 9:19 AM
jestabro committed rVYOSONEX0a32e4443c4c: vyos.configverify: T5308: fix typo revealed by tagnode aware defaults.
Jun 24 2023, 9:19 AM

Jun 23 2023

jestabro added a comment to T5308: Remove workarounds for incorrect defaults in get_interface_dict.

PR:
https://github.com/vyos/vyos-1x/pull/2052

Jun 23 2023, 5:04 PM · VyOS 1.4 Sagitta

Jun 22 2023

jestabro added a subtask for T5228: Simplify get_config_dict and add argument with_defaults: T5308: Remove workarounds for incorrect defaults in get_interface_dict.
Jun 22 2023, 1:41 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T5308: Remove workarounds for incorrect defaults in get_interface_dict: T5228: Simplify get_config_dict and add argument with_defaults.
Jun 22 2023, 1:41 PM · VyOS 1.4 Sagitta
jestabro changed the status of T5308: Remove workarounds for incorrect defaults in get_interface_dict from Open to In progress.
Jun 22 2023, 1:40 PM · VyOS 1.4 Sagitta
jestabro closed T5297: Utility function to check if config under node has been changed between revisions as Resolved.
Jun 22 2023, 1:33 PM · VyOS 1.4 Sagitta

Jun 20 2023

jestabro closed T5305: REST API configure operation should not be defined as async as Resolved.
Jun 20 2023, 6:35 PM · VyOS 1.3 Equuleus (1.3.4), VyOS 1.4 Sagitta
jestabro closed T5248: Ability to load config via API in JSON format, a subtask of T3441: More intelligent config loading scripts, as Resolved.
Jun 20 2023, 5:53 PM · VyOS Rolling
jestabro closed T5248: Ability to load config via API in JSON format, a subtask of T5263: Generalization of REST configure endpoint, as Resolved.
Jun 20 2023, 5:53 PM · VyOS 1.4 Sagitta
jestabro closed T5248: Ability to load config via API in JSON format as Resolved.
Jun 20 2023, 5:53 PM · VyOS 1.4 Sagitta
jestabro closed T5300: verification of port availability can return false negative on boot, a subtask of T5292: Commit error on boot when https.py is included in config daemon scripts, as Resolved.
Jun 20 2023, 5:46 PM · VyOS 1.4 Sagitta
jestabro closed T5300: verification of port availability can return false negative on boot as Resolved.
Jun 20 2023, 5:46 PM · VyOS 1.4 Sagitta
jestabro committed rVYOSONEX0439ade98cd8: vyos.util: T5300: check_port_availability: return False iff EADDRINUSE.
Jun 20 2023, 5:44 PM
jestabro committed rVYOSONEX33016220be8e: http-api: T5305: configure operations should not be defined async.
Jun 20 2023, 5:43 PM
jestabro changed the status of T5305: REST API configure operation should not be defined as async from Open to In progress.
Jun 20 2023, 5:34 PM · VyOS 1.3 Equuleus (1.3.4), VyOS 1.4 Sagitta
jestabro added a comment to T5300: verification of port availability can return false negative on boot.

PR:
https://github.com/vyos/vyos-1x/pull/2050

Jun 20 2023, 3:35 PM · VyOS 1.4 Sagitta

Jun 17 2023

jestabro updated the task description for T5300: verification of port availability can return false negative on boot.
Jun 17 2023, 5:16 PM · VyOS 1.4 Sagitta
jestabro closed T5292: Commit error on boot when https.py is included in config daemon scripts as Not Applicable.
Jun 17 2023, 5:15 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5292: Commit error on boot when https.py is included in config daemon scripts.

This was a red herring: root cause in
https://vyos.dev/T5300

Jun 17 2023, 5:15 PM · VyOS 1.4 Sagitta
jestabro updated the task description for T5300: verification of port availability can return false negative on boot.
Jun 17 2023, 5:13 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5262: Warn the user about unsaved config on reboot/shutdown attempts.

This is most likely due to a config error on boot, thus leaving the active config different from the saved config; cf.
'verification of port availability can return false negative on boot'
https://vyos.dev/T5300

Jun 17 2023, 5:12 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T5292: Commit error on boot when https.py is included in config daemon scripts: T5300: verification of port availability can return false negative on boot.
Jun 17 2023, 5:09 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T5300: verification of port availability can return false negative on boot: T5292: Commit error on boot when https.py is included in config daemon scripts.
Jun 17 2023, 5:09 PM · VyOS 1.4 Sagitta
jestabro changed the status of T5300: verification of port availability can return false negative on boot from Open to In progress.
Jun 17 2023, 5:09 PM · VyOS 1.4 Sagitta

Jun 16 2023

jestabro committed rVYOSONEXd35223e670be: config-mgmt: T5297: add check for changes under node between revisions.
Jun 16 2023, 7:55 PM
jestabro added a comment to T5297: Utility function to check if config under node has been changed between revisions.

PR:
https://github.com/vyos/vyos-1x/pull/2045

Jun 16 2023, 3:54 PM · VyOS 1.4 Sagitta
jestabro triaged T5297: Utility function to check if config under node has been changed between revisions as Normal priority.
Jun 16 2023, 3:37 PM · VyOS 1.4 Sagitta

Jun 15 2023

jestabro committed rVYOSONEXe1f2615453b2: configsession: T5248: load_section should not set path if dict empty.
Jun 15 2023, 8:21 PM

Jun 14 2023

jestabro committed rVYOSONEX127bc2cd3bd1: http-api: T5292: do not include https.py in scripts run by configd.
Jun 14 2023, 10:07 PM
jestabro created T5292: Commit error on boot when https.py is included in config daemon scripts.
Jun 14 2023, 9:22 PM · VyOS 1.4 Sagitta

Jun 13 2023

jestabro added a comment to T5288: Rollback 2 No-reboot feature.

cf. https://vyos.dev/T5249, currently being assessed.

Jun 13 2023, 4:28 PM · VyConf

Jun 12 2023

jestabro triaged T5248: Ability to load config via API in JSON format as Normal priority.
Jun 12 2023, 7:37 PM · VyOS 1.4 Sagitta
jestabro changed the status of T5248: Ability to load config via API in JSON format, a subtask of T3441: More intelligent config loading scripts, from Open to Needs testing.
Jun 12 2023, 7:36 PM · VyOS Rolling
jestabro changed the status of T5248: Ability to load config via API in JSON format, a subtask of T5263: Generalization of REST configure endpoint, from Open to Needs testing.
Jun 12 2023, 7:36 PM · VyOS 1.4 Sagitta
jestabro changed the status of T5248: Ability to load config via API in JSON format from Open to Needs testing.
Jun 12 2023, 7:36 PM · VyOS 1.4 Sagitta
jestabro committed rVYOSONEX701df0b70a89: http-api: T5263: simplify form errors.
Jun 12 2023, 7:16 PM
jestabro committed rVYOSONEX511591feb023: http-api: T5263: path validator should provide message.
Jun 12 2023, 7:16 PM
jestabro committed rVYOSONEXefc168bc702f: http-api: T5263: consistent string formatting.
Jun 12 2023, 7:16 PM
jestabro committed rVYOSONEX1c0d91fab1c4: http-api: T5263: factor out function _configure_op for generalization.
Jun 12 2023, 7:16 PM
jestabro committed rVYOSONEX0598c1db1114: http-api: T5263: add base model for generalization.
Jun 12 2023, 7:16 PM
jestabro committed rVYOSONEX795b259b95a4: vyos.utils: T5248: add util function: dict of list[str]|str -> list of paths.
Jun 12 2023, 7:16 PM
jestabro committed rVYOSONEXf8d75a17e2f6: configsession: T5248: add functions set/load_section.
Jun 12 2023, 7:16 PM
jestabro committed rVYOSONEXf8670aadaa2d: http-api: T5248: add endpoint /configure-section.
Jun 12 2023, 7:16 PM
jestabro closed T5282: Poweroff now does not work as Resolved.
Jun 12 2023, 5:11 PM · VyOS 1.4 Sagitta