Working directory here; PR pending:
https://github.com/vyos/vyos-1x/compare/current...jestabro:gql-simplify

https://github.com/vyos/vyos-1x/pull/1528

https://github.com/vyos/vyos-1x/pull/1529

PR:
https://github.com/vyos/vyos-1x/pull/1524

Changes for the inversion operator (--not-range instead of !) have been made. Generalizing exit codes, as suggested in PR comments will be handled in a separate task.

The PR:

Resolved in T4664: merged in Sagitta; backport candidate for Equuleus 1.3.3.

PR https://github.com/vyos/vyos-1x/pull/1328 replaced by:
https://github.com/vyos/vyos-1x/pull/1515

Initial draft; suggested changes and testing to follow:

This will be resolved by the PR in T4664.

PR: https://github.com/vyos/vyatta-cfg/pull/50

@c-po suggested the very good idea of using a migration script to remove whitespace in this case, however, upon closer inspection, we realized that this cannot work, as a result of the binding between Python and config_tree: namely, the translation uses a split_on_whitespace function which will lose access to tag node value names containing whitespace, so the name is not manipulable through standard migration techniques. One can replace split_on_whitespace with smarter translations, however, a global solution is preferable: following discussion, the suggestion is to add a check in the legacy cstore backend to reject node names containing whitespace; the future vyconf will have this check built-in. This is the approach we will investigate.

https://github.com/vyos/vyos-1x/pull/1493

@c-po @itspngu , as mentioned above, we have held off on implementing the fix, as there is a compelling argument to disallow whitespace in tag node names, just as it is disallowed in node names in general; making an exception in the case of tag node names invites problems going forward. On the other hand, thanks to the details that you provided, @itspngu, we can implement a workaround for the case of ssh-copy-id; I know of no other instance of the problem. If we do find a necessary use case of whitespace in tag node names in the future, the simple fix can then be implemented.

This is on hold, pending discussion on whether whitespace should be allowed in tag node names in 1.4.

Note that a fix for 1.4 will address the user's issue, as he is updating to 1.4-rolling, so the migration will take place upon booting into 1.4.

https://github.com/vyos/vyos1x-config/pull/11

I see the issue. Whitespace is fine in a tag node name as long as the name is quoted, however ConfigTree.to_string() does not re-quote the name, hence on the next migration script, parsing the config file will throw an error. I will investigate the proper solution.

Discussed in dev meeting today and the conclusion was to move this to 1.3.3.