Going to need to fix testing for fw_rules as a part of my current work - so picking this up...

Raised a Draft PR https://github.com/vyos/vyos.vyos/pull/368

The fix is now a part of https://github.com/vyos/vyos.vyos/pull/367

the PR to fix this is https://github.com/vyos/vyos.vyos/pull/367

The PR tp fix this https://github.com/vyos/vyos.vyos/pull/367

The PR# is re-submitted for review and testing

Raised https://github.com/vyos/vyos.vyos/pull/365

It appears that path-limit GBP network options is deprecated

I did some investigation - apparently the plugin cannot match the full command pattern (including optional attributes) and silently refuses to generate a resultant set of commands - I will be looking into this - most likely the issue is related to rm_templates regex patterns for getval

Update - I cloned the current vyo.vyos changes, created a branch and made the changes that Maxime proposed.

sure, ok - I will do needful for it to be tests ready
It does not appear a huge change to me

I believe it was forked a while ago (in March this year) and never refreshed after that - so the fork (and PK) is using older version of the repo

Sanity tests are failing pretty much all:
FATAL: The 5 sanity test(s) listed below (out of 34) failed. See error output above for details.
action-plugin-docs
import --python 3.12
pep8
pylint
validate-modules

Or I may just re-introduce the changes into the working current branch given they are all straight forward

Started to look into this - but it seems to be based on older version of collection (57 commits behind) and failing all the sanity checks.
I will try and refresh that branch and re-test

On it, @syncer

I raised a draft PR (https://github.com/vyos/vyos.vyos/pull/357) to tackle some of the compatibility issues. I will try and finalise it in coming days