Page MenuHomeVyOS Platform
Feed Search

Jul 15 2024

jestabro committed rVYOSONEX52d08b1ec5b2: configdep: T6559: use single dependency list with reset under configd.
Jul 15 2024, 6:57 AM
jestabro committed rVYOSONEX7249d10f1fbb: configdep: T6559: drop global redundancy removal to fix error reporting.
Jul 15 2024, 6:57 AM
jestabro committed rVYOSONEXad43aa885a8e: configdep: T6559: add smoketest of dependency script error.
Jul 15 2024, 6:57 AM
jestabro added a comment to T6559: vyos-configd should return commit error on config dependency error.

PR:
https://github.com/vyos/vyos-1x/pull/3813

Jul 15 2024, 5:31 AM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

Jul 12 2024

jestabro moved T5263: Generalization of REST configure endpoint from Open to Finished on the VyOS 1.4 Sagitta board.
Jul 12 2024, 7:59 PM · VyOS 1.4 Sagitta
jestabro closed T5263: Generalization of REST configure endpoint as Resolved.

This was completed at the time of T5248.

Jul 12 2024, 7:59 PM · VyOS 1.4 Sagitta

Jul 11 2024

jestabro added a comment to T6559: vyos-configd should return commit error on config dependency error.

The solution sketched above will be handled in subtask T6569; in this task we will revert to using only the local redundancy removal in order to provide per-script error reporting.

Jul 11 2024, 5:21 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro removed a subtask for T5731: Add ability to call config dependencies by canonical function instead of whole script: T6559: vyos-configd should return commit error on config dependency error.
Jul 11 2024, 5:18 PM · VyOS Rolling
jestabro removed a parent task for T6559: vyos-configd should return commit error on config dependency error: T5731: Add ability to call config dependencies by canonical function instead of whole script.
Jul 11 2024, 5:18 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro added a subtask for T5731: Add ability to call config dependencies by canonical function instead of whole script: T6569: Cache results of config script stages under configd, for use by configdep.
Jul 11 2024, 5:18 PM · VyOS Rolling
jestabro added a subtask for T6559: vyos-configd should return commit error on config dependency error: T6569: Cache results of config script stages under configd, for use by configdep.
Jul 11 2024, 5:18 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro added parent tasks for T6569: Cache results of config script stages under configd, for use by configdep: T6559: vyos-configd should return commit error on config dependency error, T5731: Add ability to call config dependencies by canonical function instead of whole script.
Jul 11 2024, 5:18 PM · VyOS Rolling
jestabro created T6569: Cache results of config script stages under configd, for use by configdep.
Jul 11 2024, 5:17 PM · VyOS Rolling

Jul 8 2024

jestabro added a subtask for T5731: Add ability to call config dependencies by canonical function instead of whole script: T6559: vyos-configd should return commit error on config dependency error.
Jul 8 2024, 12:38 AM · VyOS Rolling
jestabro added a parent task for T6559: vyos-configd should return commit error on config dependency error: T5731: Add ability to call config dependencies by canonical function instead of whole script.
Jul 8 2024, 12:38 AM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro added a comment to T6559: vyos-configd should return commit error on config dependency error.

Recovering gracefully and logging an error is a simple fix, and will be committed in the interim while the larger issue is addressed: namely, when running under vyos-configd, a ConfigError in a called dependency script should elicit a commit error in the originating config session. Here, however, we confront again the constraints of operating under the legacy commit algorithm. To address the matter, we will implement a partial solution to T5731 so as to catch verification errors in the (first instance of) sequential processing of the priority queue and cache the data for final processing of the activation stages (generate/apply); errors in the latter stages, as less common, will be logged. The sketch provided summarizes a design that balances the needs of early and correct (verify stage) error reporting with removing redundancy overhead when running under configd.

Jul 8 2024, 12:38 AM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

Jul 5 2024

jestabro created T6559: vyos-configd should return commit error on config dependency error.
Jul 5 2024, 5:44 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro committed rVYOSONEXbd42f131ea2c: migration: T6007: add missing check for None in utility function.
Jul 5 2024, 6:28 AM
jestabro added a comment to T6007: Improvements to migration system.

Bug fix in case of config file without component version string:
https://github.com/vyos/vyos-1x/pull/3788

Jul 5 2024, 1:01 AM · VyOS 1.5 Circinus

Jul 3 2024

jestabro added a comment to T6300: [1.3->1.4 Migration] An empty interface configuration drops all interfaces configuration.

@a.apostoliuk if you accept the explanation above and the workaround suffices (as recently discussed), we will close this task.

Jul 3 2024, 5:51 PM · Bugs, VyOS 1.4 Sagitta (1.4.1)
jestabro removed a subtask for T5938: Migration fail root task for 1.4-rc: T5991: 1.4.0-RC3 deleting portions of config in error (migration script).
Jul 3 2024, 5:46 PM · VyOS Rolling, Bugs
jestabro removed a parent task for T5991: 1.4.0-RC3 deleting portions of config in error (migration script): T5938: Migration fail root task for 1.4-rc.
Jul 3 2024, 5:46 PM · Bugs, VyOS 1.4 Sagitta (1.4.1)
jestabro added a comment to T5991: 1.4.0-RC3 deleting portions of config in error (migration script).

Adding parent T6543 as contributing factor of issue in comment:
https://vyos.dev/T5991#178786

Jul 3 2024, 5:45 PM · Bugs, VyOS 1.4 Sagitta (1.4.1)
jestabro added a subtask for T6543: Legacy load config ignores validation errors on set, leading to removal of config sections under commit error: T5991: 1.4.0-RC3 deleting portions of config in error (migration script).
Jul 3 2024, 5:43 PM · VyOS Rolling, Bugs
jestabro added a parent task for T5991: 1.4.0-RC3 deleting portions of config in error (migration script): T6543: Legacy load config ignores validation errors on set, leading to removal of config sections under commit error.
Jul 3 2024, 5:43 PM · Bugs, VyOS 1.4 Sagitta (1.4.1)
jestabro closed T3875: Known issues with vyatta_net_name/vyatta_interface_rescan as Not Applicable.

The biosdevname question is a matter for T5603; this task will be closed.

Jul 3 2024, 5:29 PM
jestabro closed T3875: Known issues with vyatta_net_name/vyatta_interface_rescan, a subtask of T3869: Rewrite vyatta_net_name/vyatta_interface_rescan in Python, as Not Applicable.
Jul 3 2024, 5:29 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T5528: Replace legacy loadFile with config_diff: T5400: Move libvyosconfig build out of the Docker image.
Jul 3 2024, 5:24 PM · VyOS Rolling
jestabro added a parent task for T5400: Move libvyosconfig build out of the Docker image: T5528: Replace legacy loadFile with config_diff.
Jul 3 2024, 5:24 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q2), VyOS Rolling
jestabro edited projects for T5400: Move libvyosconfig build out of the Docker image, added: VyOS 1.5 Circinus; removed VyOS 1.4 Sagitta (1.4.0-GA).

A version of this change will be part of T5528, only for Circinus initially.

Jul 3 2024, 5:24 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q2), VyOS Rolling
jestabro claimed T3441: More intelligent config loading scripts.
Jul 3 2024, 5:13 PM · VyOS Rolling
jestabro created T6543: Legacy load config ignores validation errors on set, leading to removal of config sections under commit error.
Jul 3 2024, 3:32 PM · VyOS Rolling, Bugs
jestabro committed rVYOSONEX977d2fbf7a62: syslog: T5366: remove reference to deprecated sysvinit rsyslog script.
Jul 3 2024, 2:49 PM
jestabro added a project to T5366: syslog: remove outdated reference to sysvinit rsyslog file in logrotate template: VyOS 1.5 Circinus.
Jul 3 2024, 2:31 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus, VyOS Rolling, Bugs
jestabro added a comment to T5366: syslog: remove outdated reference to sysvinit rsyslog file in logrotate template.

Spring cleaning PR:
https://github.com/vyos/vyos-1x/pull/3760

Jul 3 2024, 2:31 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus, VyOS Rolling, Bugs
jestabro updated the task description for T5366: syslog: remove outdated reference to sysvinit rsyslog file in logrotate template.
Jul 3 2024, 2:31 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus, VyOS Rolling, Bugs
jestabro moved T5527: Adjust for change in coreutils behavior on overlayfs from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.0) board.
Jul 3 2024, 1:25 PM · VyOS 1.4 Sagitta (1.4.0)
jestabro closed T5527: Adjust for change in coreutils behavior on overlayfs, a subtask of T5520: Likely source of corruption on system update exposed by change in coreutils for Bookworm, as Resolved.
Jul 3 2024, 1:25 PM · VyOS 1.4 Sagitta
jestabro closed T5527: Adjust for change in coreutils behavior on overlayfs as Resolved.

The critical issue was addressed in T5520, and the matter avoided with the move to revised image tools. No more to do on this at this point, and will close.

Jul 3 2024, 1:25 PM · VyOS 1.4 Sagitta (1.4.0)

Jul 2 2024

jestabro closed T5947: [1.3.2 -> 1.4.0-RC1 Migration] Static ipv6 routes dropped, a subtask of T5611: Difference in config file after interface MAC changed, as Resolved.
Jul 2 2024, 8:16 PM · VyOS Rolling, Bugs
jestabro closed T5947: [1.3.2 -> 1.4.0-RC1 Migration] Static ipv6 routes dropped as Resolved.

Added T5611 as parent task, as it is clearly the root cause from the description above. As mentioned in T5611 the workaround of saving the config on the source system is needed due to incompatibility of the legacy parser.

Jul 2 2024, 8:16 PM · VyOS Rolling
jestabro closed T5947: [1.3.2 -> 1.4.0-RC1 Migration] Static ipv6 routes dropped, a subtask of T5938: Migration fail root task for 1.4-rc, as Resolved.
Jul 2 2024, 8:16 PM · VyOS Rolling, Bugs
jestabro added a comment to T5611: Difference in config file after interface MAC changed.

Added child/related task T6300; the issue is explained in the above comment and in that task. As has been discussed, the easiest workaround is to save the config on the source image before migrating --- backporting the rewrite of vyatta_net_name/vyatta_interface_rescan to 1.3.x will not resolve the issue for earlier images, so a workaround is needed in those cases.

Jul 2 2024, 8:14 PM · VyOS Rolling, Bugs
jestabro added a subtask for T5611: Difference in config file after interface MAC changed: T5947: [1.3.2 -> 1.4.0-RC1 Migration] Static ipv6 routes dropped.
Jul 2 2024, 8:06 PM · VyOS Rolling, Bugs
jestabro added a parent task for T5947: [1.3.2 -> 1.4.0-RC1 Migration] Static ipv6 routes dropped: T5611: Difference in config file after interface MAC changed.
Jul 2 2024, 8:06 PM · VyOS Rolling
jestabro added a comment to T6300: [1.3->1.4 Migration] An empty interface configuration drops all interfaces configuration.

Added parent task T5611; the issue is explained in the above comment and in that task. As has been discussed, the easiest workaround is to save the config on the source image before migrating --- backporting the rewrite of vyatta_net_name/vyatta_interface_rescan to 1.3.x, as mentioned in T5611, will not resolve the issue for earlier images, so a workaround is needed in those cases.

Jul 2 2024, 7:59 PM · Bugs, VyOS 1.4 Sagitta (1.4.1)
jestabro added a subtask for T5611: Difference in config file after interface MAC changed: T6300: [1.3->1.4 Migration] An empty interface configuration drops all interfaces configuration.
Jul 2 2024, 7:53 PM · VyOS Rolling, Bugs
jestabro added a parent task for T6300: [1.3->1.4 Migration] An empty interface configuration drops all interfaces configuration: T5611: Difference in config file after interface MAC changed.
Jul 2 2024, 7:53 PM · Bugs, VyOS 1.4 Sagitta (1.4.1)
jestabro moved T6022: set system image default-boot from Need Triage to Finished on the VyOS 1.4 Sagitta (1.4.0) board.
Jul 2 2024, 7:49 PM · VyOS 1.4 Sagitta (1.4.0)
jestabro edited projects for T6022: set system image default-boot, added: VyOS 1.4 Sagitta (1.4.0); removed VyOS 1.4 Sagitta (1.4.1).
Jul 2 2024, 7:48 PM · VyOS 1.4 Sagitta (1.4.0)
jestabro closed T6022: set system image default-boot as Resolved.

As mentioned above, the main regression was fixed; as to the other issue of "‘show system image’ list may not reflect the actual default boot image" I was unable to reproduce originally, but likely fixed as well, as the regression in question corrupted the image list and annotations. Close as fixed; reopen as needed.

Jul 2 2024, 7:47 PM · VyOS 1.4 Sagitta (1.4.0)
jestabro added a comment to T5528: Replace legacy loadFile with config_diff.

This will be readied for PR without adding the external package vyos1x-adapter; that version has already been completed and will be linked below.

Jul 2 2024, 6:39 PM · VyOS Rolling
jestabro closed T6006: Configure system-specific capabilities independently of migration scripts, a subtask of T3821: Add latest versions to default config files, as Resolved.
Jul 2 2024, 6:37 PM · VyOS 1.5 Circinus
jestabro closed T6006: Configure system-specific capabilities independently of migration scripts, a subtask of T3275: Disable conntrack helpers by default, as Resolved.
Jul 2 2024, 6:37 PM · VyOS 1.5 Circinus
jestabro closed T6006: Configure system-specific capabilities independently of migration scripts as Resolved.
Jul 2 2024, 6:37 PM · VyOS 1.5 Circinus
jestabro closed T6006: Configure system-specific capabilities independently of migration scripts, a subtask of T6007: Improvements to migration system, as Resolved.
Jul 2 2024, 6:37 PM · VyOS 1.5 Circinus
jestabro closed T6006: Configure system-specific capabilities independently of migration scripts, a subtask of T3824: Ethernet offload options are not populated in new installs, as Resolved.
Jul 2 2024, 6:37 PM
jestabro changed the status of T6447: Add module for iterating over modifications to a config file from Unknown Status to Resolved.
Jul 2 2024, 6:36 PM · VyOS 1.5 Circinus
jestabro changed the status of T6447: Add module for iterating over modifications to a config file, a subtask of T6006: Configure system-specific capabilities independently of migration scripts, from Unknown Status to Resolved.
Jul 2 2024, 6:36 PM · VyOS 1.5 Circinus
jestabro closed T6447: Add module for iterating over modifications to a config file as Unknown Status.
Jul 2 2024, 6:34 PM · VyOS 1.5 Circinus
jestabro closed T6447: Add module for iterating over modifications to a config file, a subtask of T6006: Configure system-specific capabilities independently of migration scripts, as Unknown Status.
Jul 2 2024, 6:34 PM · VyOS 1.5 Circinus

Jun 28 2024

jestabro added a subtask for T6471: Add an optimized get_config_dict for op-mode: T6531: Extend optimization of op_mode_config_dict to ConfigTreeQuery class.
Jun 28 2024, 5:14 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro added a parent task for T6531: Extend optimization of op_mode_config_dict to ConfigTreeQuery class: T6471: Add an optimized get_config_dict for op-mode.
Jun 28 2024, 5:14 PM · VyOS Rolling
jestabro created T6531: Extend optimization of op_mode_config_dict to ConfigTreeQuery class.
Jun 28 2024, 5:13 PM · VyOS Rolling
jestabro closed T6007: Improvements to migration system, a subtask of T6302: The root task for bugs and improvements related to commit time and boot, as Unknown Status.
Jun 28 2024, 5:03 PM · VyOS Rolling, Bugs
jestabro closed T6007: Improvements to migration system as Unknown Status.

PR merged:
https://github.com/vyos/vyos-1x/pull/3692

Jun 28 2024, 5:03 PM · VyOS 1.5 Circinus

Jun 27 2024

jestabro committed rVYOSONEX8a57e7b14c81: migration: T6007: use load_as_module_source for files without extension.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEX23356ee43534: vyos.utils.dict: T5195: fix syntax warning.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEX1c59315e9d14: migration: T6447: add traceback on error.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEX734db72b9161: migration: T6447: fix missing check before reset to checkpoint.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEX601e07c34205: migration: T6007: add version object for config file and system.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEX83ca4a5a6ed0: migration: T6007: add exception in base for use by migration files.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEX26740a8d583f: migration: T6007: convert all migration scripts to load as module.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEX271fcff986c1: migration: T6007: update vyos-load-config.py.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEX9388f6278384: migration: T6007: write configtree operations to log.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEXad4f8312f6a3: migration: T6007: drop check for executable scripts, as now modules.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEXea714891a0d6: migration: T6007: update migration class.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEXcd347713196c: migration: T6007: update vyos_net_name.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEXf67753bf10ac: migration: T6007: update vyos-merge-config.py.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEX403f1d2f2159: migration: T6007: update load_config.py.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEX51865448599e: migration: T6007: add util add_system_version to replace *_system_footer.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEX08d4fcbc6243: migration: T6007: update run-config-migration script.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEXed0cb7ffc2c6: migration: T6007: remove obsoleted.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEX8b4c2fcba2fe: migration: T6007: drop restrictive perms, already set on config.boot.
Jun 27 2024, 1:40 PM
jestabro committed rVYOSONEX5502a75b1747: migration: T6007: fix cosmetic issue of extra newline.
Jun 27 2024, 1:40 PM

Jun 24 2024

jestabro closed T6504: login: user vyos cannot be deleted under vyos-configd as Resolved.
Jun 24 2024, 5:35 PM · VyOS 1.5 Circinus (2025.11), VyOS 1.4 Sagitta (1.4.4)
jestabro closed T6504: login: user vyos cannot be deleted under vyos-configd, a subtask of T6489: Add/Improve support for CLI config scripts that change the underlying actual configuration and make them work with vyos-configd, as Resolved.
Jun 24 2024, 5:35 PM · VyOS 1.5 Circinus (2025.11), VyOS 1.4 Sagitta (1.4.4)
jestabro committed rVYOSONEX7016f840f119: configd: T6504: send sudo_user on session init and set env variable.
Jun 24 2024, 2:02 PM

Jun 21 2024

jestabro added a comment to T6504: login: user vyos cannot be deleted under vyos-configd.

PR:
https://github.com/vyos/vyos-1x/pull/3701

Jun 21 2024, 7:30 PM · VyOS 1.5 Circinus (2025.11), VyOS 1.4 Sagitta (1.4.4)
jestabro added a comment to T6504: login: user vyos cannot be deleted under vyos-configd.

My current understanding, and memory of its introduction, is that the settings os.environ[SUDO_*] were more than needed at the time, with a possible later use in mind: the only critical setting for vyos-configd as a dispatcher of config mode scripts is the preceding line: setgid(cfg_group.gid), allowing the config group access to generated files. Note that the environment variables are not currently used by conf-mode scripts, other than system_login.py, leading to the above bug.

Jun 21 2024, 3:21 AM · VyOS 1.5 Circinus (2025.11), VyOS 1.4 Sagitta (1.4.4)

Jun 20 2024

jestabro changed the status of T6007: Improvements to migration system from Open to In progress.

Draft PR passes configtests; dramatically faster:
https://github.com/vyos/vyos-1x/pull/3692
Minor integration and other testing remain before ready for review.

Jun 20 2024, 1:42 PM · VyOS 1.5 Circinus

Jun 11 2024

jestabro closed T6471: Add an optimized get_config_dict for op-mode as Resolved.
Jun 11 2024, 1:32 PM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro committed rVYOSONEX1a164852d2cb: op-mode: T6471: add optimized get_config_dict.
Jun 11 2024, 8:00 AM
jestabro added a comment to T6471: Add an optimized get_config_dict for op-mode.

PR:
https://github.com/vyos/vyos-1x/pull/3628

Jun 11 2024, 3:45 AM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus
jestabro created T6471: Add an optimized get_config_dict for op-mode.
Jun 11 2024, 2:32 AM · VyOS 1.4 Sagitta (1.4.1), VyOS 1.5 Circinus

Jun 6 2024

jestabro moved T3821: Add latest versions to default config files from Open to Finished on the VyOS 1.5 Circinus board.
Jun 6 2024, 4:20 PM · VyOS 1.5 Circinus
jestabro closed T3275: Disable conntrack helpers by default as Resolved.

Resolved by T6006.

Jun 6 2024, 4:20 PM · VyOS 1.5 Circinus
jestabro closed T3821: Add latest versions to default config files as Resolved.
Jun 6 2024, 4:18 PM · VyOS 1.5 Circinus
jestabro closed T3821: Add latest versions to default config files, a subtask of T3275: Disable conntrack helpers by default, as Resolved.
Jun 6 2024, 4:18 PM · VyOS 1.5 Circinus
jestabro added a comment to T3821: Add latest versions to default config files.

Resolved by PR merged in T6006.

Jun 6 2024, 4:17 PM · VyOS 1.5 Circinus