Page MenuHomeVyOS Platform
Feed Search

Jun 12 2023

jestabro committed rVYOSONEX01028cf993e4: T5282: remove systemd management directive for frr.service.
Jun 12 2023, 4:54 PM
jestabro claimed T5282: Poweroff now does not work.

PR:
https://github.com/vyos/vyos-1x/pull/2039

Jun 12 2023, 4:31 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5282: Poweroff now does not work.

After T5239, (vyatta-cfg, commit 4bbb3829), frr.service start and stop is managed by vyos-router, consequently, one should remove the following, so as not to confuse systemd:
https://github.com/vyos/vyos-1x/blob/current/src/etc/systemd/system/frr.service.d/override.conf#L1-L3

Jun 12 2023, 3:54 PM · VyOS 1.4 Sagitta

Jun 11 2023

jestabro added a subtask for T3441: More intelligent config loading scripts: T5248: Ability to load config via API in JSON format.
Jun 11 2023, 2:43 AM · VyOS Rolling
jestabro added a parent task for T5248: Ability to load config via API in JSON format: T3441: More intelligent config loading scripts.
Jun 11 2023, 2:43 AM · VyOS 1.4 Sagitta
jestabro added a comment to T5248: Ability to load config via API in JSON format.

PR:
https://github.com/vyos/vyos-1x/pull/2037

Jun 11 2023, 2:39 AM · VyOS 1.4 Sagitta

Jun 8 2023

jestabro added a subtask for T5136: Possible config corruption on upgrade: T5267: Another corruption on upgrade.
Jun 8 2023, 3:04 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro added a parent task for T5267: Another corruption on upgrade: T5136: Possible config corruption on upgrade.
Jun 8 2023, 3:04 PM · VyOS 1.4 Sagitta

Jun 7 2023

jestabro committed rVYOSONEXef3a9babe6e0: op-mode: T5262: use module function instead of method.
Jun 7 2023, 2:19 PM
jestabro committed rVYOSONEX83c8bcd9ddd8: config-mgmt: T5262: move function 'unsaved_commits' to module scope.
Jun 7 2023, 2:19 PM

Jun 6 2023

jestabro added a parent task for T5248: Ability to load config via API in JSON format: T5263: Generalization of REST configure endpoint.
Jun 6 2023, 10:32 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T5263: Generalization of REST configure endpoint: T5248: Ability to load config via API in JSON format.
Jun 6 2023, 10:32 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T3955: Allow commit-confirm through http API: T5263: Generalization of REST configure endpoint.
Jun 6 2023, 10:31 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q2), VyOS Rolling
jestabro added a subtask for T5263: Generalization of REST configure endpoint: T3955: Allow commit-confirm through http API.
Jun 6 2023, 10:31 PM · VyOS 1.4 Sagitta
jestabro triaged T5263: Generalization of REST configure endpoint as Normal priority.
Jun 6 2023, 10:31 PM · VyOS 1.4 Sagitta
jestabro committed rVYOSONEXee14f9cd2831: dns: T5144: update conf script name.
Jun 6 2023, 1:23 PM

Jun 5 2023

jestabro moved T5259: Openconnect cannot pass migration 1-to-2 from Open to Finished on the VyOS 1.4 Sagitta board.
Jun 5 2023, 5:40 PM · VyOS 1.4 Sagitta
jestabro closed T5259: Openconnect cannot pass migration 1-to-2, a subtask of T5251: Uncaught errors for functions delete/delete_value in Python module configtree.py, as Resolved.
Jun 5 2023, 4:53 PM · VyOS 1.4 Sagitta
jestabro closed T5259: Openconnect cannot pass migration 1-to-2 as Resolved.
Jun 5 2023, 4:53 PM · VyOS 1.4 Sagitta
jestabro committed rVYOSONEX2ce55816aad8: openconnect: T5259: fix migration logic in delete_value radius|local.
Jun 5 2023, 4:53 PM
jestabro changed the status of T5259: Openconnect cannot pass migration 1-to-2 from Open to In progress.
Jun 5 2023, 4:48 PM · VyOS 1.4 Sagitta
jestabro changed the status of T5259: Openconnect cannot pass migration 1-to-2, a subtask of T5251: Uncaught errors for functions delete/delete_value in Python module configtree.py, from Open to In progress.
Jun 5 2023, 4:48 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T5251: Uncaught errors for functions delete/delete_value in Python module configtree.py: T5259: Openconnect cannot pass migration 1-to-2.
Jun 5 2023, 4:47 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T5259: Openconnect cannot pass migration 1-to-2: T5251: Uncaught errors for functions delete/delete_value in Python module configtree.py.
Jun 5 2023, 4:47 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5259: Openconnect cannot pass migration 1-to-2.

PR:
https://github.com/vyos/vyos-1x/pull/2026

Jun 5 2023, 4:47 PM · VyOS 1.4 Sagitta
jestabro claimed T5259: Openconnect cannot pass migration 1-to-2.
Jun 5 2023, 2:35 PM · VyOS 1.4 Sagitta

Jun 4 2023

jestabro added a comment to T5228: Simplify get_config_dict and add argument with_defaults.

Draft PR re-opened following fix of regression with option 'recursive'; simplified logic and added optional args to get_config_defaults to mirror get_config_dict. The latter allows easy manipulation of defaults in cases where the automatic merge is not sufficient.

Jun 4 2023, 3:54 AM · VyOS 1.4 Sagitta

Jun 2 2023

jestabro closed T5251: Uncaught errors for functions delete/delete_value in Python module configtree.py as Resolved.
Jun 2 2023, 1:44 PM · VyOS 1.4 Sagitta
jestabro committed rVYOSONEX4dbbacc5ff72: configtree: T5251: catch/raise error in delete and delete_value.
Jun 2 2023, 1:07 PM
jestabro committed rVYOSONEX362ece3add27: migration: T5251: fix incorrect logic in calling configtree.delete.
Jun 2 2023, 1:07 PM

May 31 2023

jestabro added a comment to T5251: Uncaught errors for functions delete/delete_value in Python module configtree.py.

PR's:
https://github.com/vyos/libvyosconfig/pull/11 (merged)
https://github.com/vyos/vyos-1x/pull/2023

May 31 2023, 11:28 PM · VyOS 1.4 Sagitta
jestabro triaged T5251: Uncaught errors for functions delete/delete_value in Python module configtree.py as Normal priority.
May 31 2023, 8:47 PM · VyOS 1.4 Sagitta
jestabro claimed T5248: Ability to load config via API in JSON format.
May 31 2023, 3:23 PM · VyOS 1.4 Sagitta
jestabro claimed T5249: Add rollback-soft feature to rollback without a reboot.
May 31 2023, 3:11 PM · VyOS 1.5 Circinus, VyOS 1.4 Sagitta

May 28 2023

jestabro added a subtask for T4942: Rewrite vyatta-config-mgmt to Python/XML: T3955: Allow commit-confirm through http API.
May 28 2023, 9:32 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T3955: Allow commit-confirm through http API: T4942: Rewrite vyatta-config-mgmt to Python/XML.
May 28 2023, 9:32 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q2), VyOS Rolling
jestabro claimed T3955: Allow commit-confirm through http API.
May 28 2023, 8:40 PM · VyOS 1.5 Circinus (1.5-stream-2025-Q2), VyOS Rolling

May 27 2023

jestabro committed rVYOSONEXbec69832ef2d: T5242: example use of cli_defined.
May 27 2023, 9:34 AM
jestabro committed rVYOSONEX2ba5207ed967: xml: T5242: add cli_defined boolean test for node existing under path.
May 27 2023, 9:34 AM

May 26 2023

jestabro added a comment to T5242: interfaces: smoketest: automatically detect "capabilities".

Added extension and example for test_vif_8021q_mtu_limits.

May 26 2023, 8:08 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5242: interfaces: smoketest: automatically detect "capabilities".

One fix added; I'm looking at an extension for the case of test_vif_8021q_mtu_limits, as mentioned in the comment in base_interfaces_test.py.

May 26 2023, 6:27 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5242: interfaces: smoketest: automatically detect "capabilities".
May 26 2023, 6:13 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5242: interfaces: smoketest: automatically detect "capabilities".

Example implementation:
https://github.com/vyos/vyos-1x/compare/current...jestabro:cli-defined

May 26 2023, 1:40 PM · VyOS 1.4 Sagitta

May 21 2023

jestabro closed T5218: Revise vyos xml lib for bug fixes and extensions, a subtask of T2665: vyos.xml.defaults for tag nodes, as Resolved.
May 21 2023, 11:31 PM · VyOS 1.4 Sagitta
jestabro closed T5218: Revise vyos xml lib for bug fixes and extensions as Resolved.
May 21 2023, 11:31 PM · VyOS 1.4 Sagitta
jestabro committed rVYOSONEXe8bfd3c7dcf5: configtree: T5194: add function reference_tree_to_json.
May 21 2023, 4:29 AM
jestabro committed rVYOSONEX222f459d82ec: xml: T5218: add operations on xml cache.
May 21 2023, 4:29 AM
jestabro committed rVYOSONEXec4f1851058c: xml: T5218: generate xml cache from reference_tree.
May 21 2023, 4:29 AM
jestabro committed rVYOSONEXd958f00dda8b: xml: T5218: return defaults only for child leaf-nodes, unless recursive.
May 21 2023, 4:29 AM

May 20 2023

jestabro committed rVYOSONEX654b38da3ec2: T5230: remove trailing tabs causing j2lint error.
May 20 2023, 1:47 AM

May 17 2023

jestabro added a comment to T5228: Simplify get_config_dict and add argument with_defaults.

Draft until the dependency PR is merged:
https://github.com/vyos/vyos-1x/pull/1997

May 17 2023, 9:10 PM · VyOS 1.4 Sagitta
jestabro added a subtask for T5218: Revise vyos xml lib for bug fixes and extensions: T5228: Simplify get_config_dict and add argument with_defaults.
May 17 2023, 6:29 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T5228: Simplify get_config_dict and add argument with_defaults: T5218: Revise vyos xml lib for bug fixes and extensions.
May 17 2023, 6:29 PM · VyOS 1.4 Sagitta
jestabro changed the status of T5228: Simplify get_config_dict and add argument with_defaults from Open to In progress.
May 17 2023, 6:29 PM · VyOS 1.4 Sagitta

May 16 2023

jestabro closed T5194: Add reference tree to vyos1x-config as Resolved.
May 16 2023, 6:31 PM · VyOS 1.4 Sagitta

May 11 2023

jestabro added a comment to T5194: Add reference tree to vyos1x-config.

PR:
https://github.com/vyos/vyos1x-config/pull/17

May 11 2023, 1:47 PM · VyOS 1.4 Sagitta

May 10 2023

jestabro added a subtask for T2665: vyos.xml.defaults for tag nodes: T5218: Revise vyos xml lib for bug fixes and extensions.
May 10 2023, 10:17 PM · VyOS 1.4 Sagitta
jestabro added a parent task for T5218: Revise vyos xml lib for bug fixes and extensions: T2665: vyos.xml.defaults for tag nodes.
May 10 2023, 10:16 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5218: Revise vyos xml lib for bug fixes and extensions.

PR:
https://github.com/vyos/vyos-1x/pull/1997
This will remain in draft until corresponding PR fro vyos1x-config is merged.

May 10 2023, 10:16 PM · VyOS 1.4 Sagitta
jestabro changed the status of T5218: Revise vyos xml lib for bug fixes and extensions from Open to In progress.
May 10 2023, 10:01 PM · VyOS 1.4 Sagitta

May 1 2023

jestabro changed the status of T5194: Add reference tree to vyos1x-config from Open to In progress.
May 1 2023, 3:59 PM · VyOS 1.4 Sagitta

Apr 27 2023

jestabro closed T5185: Static IPv6 route with blackhole fails as Resolved.
Apr 27 2023, 4:20 PM · VyOS 1.4 Sagitta
jestabro changed the status of T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0 from Unknown Status to Resolved.
Apr 27 2023, 2:09 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro changed the status of T5176: http-api: update vyos-http-api-tools for FastAPI security vulnerability, a subtask of T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0, from Unknown Status to Resolved.
Apr 27 2023, 2:03 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro changed the status of T5176: http-api: update vyos-http-api-tools for FastAPI security vulnerability from Unknown Status to Resolved.
Apr 27 2023, 2:02 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro committed rVYOSONEXb8920d636aec: http-api: T5175: check value of attribute for FastAPI>=0.91.0.
Apr 27 2023, 1:26 PM

Apr 26 2023

jestabro added a comment to T5183: IPv6 route6 problem.

Thanks for opening the task; note that Viacheslav had opened
https://vyos.dev/T5185
as well, and the updates on the now fixed issue can be found there. This task can be merged into that one and closed.

Apr 26 2023, 8:03 PM · VyOS 1.4 Sagitta
jestabro added a comment to T5185: Static IPv6 route with blackhole fails.

Merged and repos updated, so this will be in the next nightly build. Note that for a local build, one will need an updated Docker image for the update to vyos1x-config.

Apr 26 2023, 8:00 PM · VyOS 1.4 Sagitta
jestabro changed the status of T5185: Static IPv6 route with blackhole fails from Open to In progress.

This is a simple bug in the recently introduced configtree node name comparison function; fixed and should be in next rolling.

Apr 26 2023, 5:38 PM · VyOS 1.4 Sagitta
jestabro triaged T5185: Static IPv6 route with blackhole fails as Urgent! priority.
Apr 26 2023, 4:33 PM · VyOS 1.4 Sagitta
jestabro claimed T5185: Static IPv6 route with blackhole fails.
Apr 26 2023, 4:29 PM · VyOS 1.4 Sagitta

Apr 25 2023

jestabro closed T5179: multi nodes defined in XML are not properly represented as list in get_config_dict(), a subtask of T3234: multi_to_list fails in certain cases, with root cause an element redundancy in XML interface-definitions, as Resolved.
Apr 25 2023, 9:08 PM · VyOS 1.3 Equuleus (1.3.0-epa1), VyOS 1.4 Sagitta
jestabro closed T5179: multi nodes defined in XML are not properly represented as list in get_config_dict() as Resolved.
Apr 25 2023, 9:08 PM · VyOS 1.4 Sagitta
jestabro committed rVYOSONEXa50aa1732a54: xml: T5179: fix missed case in multi_to_list conversion.
Apr 25 2023, 8:08 PM
jestabro renamed T5178: Fix missed case in multi_to_list conversion from Fix misssed case in multi_to_list conversion to Fix missed case in multi_to_list conversion.
Apr 25 2023, 1:43 PM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta
jestabro added a comment to T5179: multi nodes defined in XML are not properly represented as list in get_config_dict().

Test case above produces:

Apr 25 2023, 6:00 AM · VyOS 1.4 Sagitta
jestabro added a comment to T5179: multi nodes defined in XML are not properly represented as list in get_config_dict().

PR:
https://github.com/vyos/vyos-1x/pull/1970

Apr 25 2023, 5:57 AM · VyOS 1.4 Sagitta
jestabro added a comment to T5179: multi nodes defined in XML are not properly represented as list in get_config_dict().

Merged T5178 into this one; cf. the description there for background of the issue.

Apr 25 2023, 5:22 AM · VyOS 1.4 Sagitta
jestabro merged task T5178: Fix missed case in multi_to_list conversion into T5179: multi nodes defined in XML are not properly represented as list in get_config_dict().
Apr 25 2023, 5:20 AM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta
jestabro merged T5178: Fix missed case in multi_to_list conversion into T5179: multi nodes defined in XML are not properly represented as list in get_config_dict().
Apr 25 2023, 5:20 AM · VyOS 1.4 Sagitta
jestabro changed the status of T5178: Fix missed case in multi_to_list conversion from Open to In progress.
Apr 25 2023, 5:15 AM · VyOS 1.3 Equuleus, VyOS 1.4 Sagitta

Apr 24 2023

jestabro edited projects for T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0, added: VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus.

PR for equuleus:
https://github.com/vyos/vyos-1x/pull/1969

Apr 24 2023, 5:56 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro edited projects for T5176: http-api: update vyos-http-api-tools for FastAPI security vulnerability, added: VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus.

PR for equuleus:
https://github.com/vyos/vyos-http-api-tools/pull/5

Apr 24 2023, 5:55 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro changed the status of T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0 from Unknown Status to Unknown Status.
Apr 24 2023, 2:03 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro closed T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0 as Unknown Status.
Apr 24 2023, 2:03 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro closed T5176: http-api: update vyos-http-api-tools for FastAPI security vulnerability, a subtask of T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0, as Unknown Status.
Apr 24 2023, 2:03 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro closed T5176: http-api: update vyos-http-api-tools for FastAPI security vulnerability as Unknown Status.
Apr 24 2023, 2:03 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro committed rVYOSONEX59400fbf3ea3: http-api: T5175: check value of attribute for FastAPI>=0.91.0.
Apr 24 2023, 1:50 PM

Apr 23 2023

jestabro added a subtask for T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0: T5176: http-api: update vyos-http-api-tools for FastAPI security vulnerability.
Apr 23 2023, 9:11 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro added a parent task for T5176: http-api: update vyos-http-api-tools for FastAPI security vulnerability: T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0.
Apr 23 2023, 9:11 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro triaged T5176: http-api: update vyos-http-api-tools for FastAPI security vulnerability as High priority.
Apr 23 2023, 9:11 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro changed the status of T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0 from Open to In progress.
Apr 23 2023, 8:35 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro added a comment to T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0.

This has a simple fix: starlette commit c568b55d set the attribute

Request._form = None

to support use of Request.form() as a context manager. Since we override the Request class for backwards-compatibility support (translation) of form-data requests, we need to check for value, not existence, of the attribute. Adding this fix allows updating FastAPI past 0.91.0.

Apr 23 2023, 8:35 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro renamed T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0 from http-api: error in MultiPart parser for FastAPI version >= 0.90.0 to http-api: error in MultiPart parser for FastAPI version >= 0.91.0.
Apr 23 2023, 8:29 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro renamed T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0 from http-api: error in MultipPart parser for FastAPI version >= 0.90.0 to http-api: error in MultiPart parser for FastAPI version >= 0.90.0.
Apr 23 2023, 2:10 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro updated the task description for T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0.
Apr 23 2023, 1:44 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta
jestabro triaged T5175: http-api: error in MultiPart parser for FastAPI version >= 0.91.0 as Urgent! priority.
Apr 23 2023, 1:39 PM · VyOS 1.3 Equuleus (1.3.3), VyOS 1.4 Sagitta

Apr 13 2023

jestabro changed the status of T2612: HTTPS API, changing API key fails but goes through from On hold to Open.

Self-configuration of the http-api calls a service restart from the config mode script: some re-configuration should be possible without restart; the remaining should provide an explanatory 'success' response. Move to high-priority to address.

Apr 13 2023, 8:33 PM · VyOS 1.3 Equuleus (1.3.7), VyOS 1.5 Circinus, VyOS 1.4 Sagitta
jestabro edited projects for T1185: Firewall rulesets are ignored in RFC-compliant VRRP setups, added: VyOS 1.4 Sagitta, VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).
Apr 13 2023, 8:32 PM
jestabro edited projects for T3980: vrrp transition-script validator makes warning fatal and also causes a python NameError exception, added: VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).
Apr 13 2023, 7:57 PM · VyOS 1.3 Equuleus (1.3.6)