Backport PR:
https://github.com/vyos/vyos-1x/pull/1874
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feed Search
Mar 8 2023
Mar 8 2023
jestabro changed the status of T4872: Op-mode show openvpn misses a case when parsing for tunnel IP from Unknown Status to Resolved.
jestabro committed rVYOSONEXbdfd55a2847d: openvpn: T4381: Add tunnel ip column for status command (authored by SrividyaA).
Mar 7 2023
Mar 7 2023
jestabro changed the status of T4900: Cache intermediary results of get_config_diff in Config instance from Unknown Status to Resolved.
jestabro moved T4381: OpenVPN: Add "Tunnel IP" column in "show openvpn server" operational command from Open to Finished on the VyOS 1.4 Sagitta board.
jestabro closed T4381: OpenVPN: Add "Tunnel IP" column in "show openvpn server" operational command as Unknown Status.
Backport PR for this and T4872:
https://github.com/vyos/vyos-1x/pull/1874
jestabro moved T2649: Ensure configration mode scripts conform to coding guidelines from Need Triage to Finished on the VyOS 1.3 Equuleus board.
jestabro closed T2649: Ensure configration mode scripts conform to coding guidelines, a subtask of T2582: Script daemon to offload processing during commit, as Resolved.
This was a meta-task for conformance to coding guidelines for inclusion of scripts in vyos-configd. Those guidelines are documented and checked in the smoketest test_configd_inspect.py for both Sagitta and Equuleus, and will be closed.
jestabro edited projects for T3574: Add constraintGroup for combining validators with logical AND, added: VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).
This is potentially a useful feature, but has no current use, so there is no reason to backport it for 1.3.3. I wil add a 1.3.4 tag to keep it in mind in case it is needed for a future backport.
jestabro moved T2838: Ethernet device names changing, multiple hw-id being added from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.3) board.
As mentioned above, there were two separate issues here:
(1) the issue of quoting of hw-id values is resolved in this task, for both Sagitta and Equuleus
Mar 5 2023
Mar 5 2023
jestabro closed T5040: Generate API GraphQL schema on installation, rather than dynamically as Resolved.
Mar 4 2023
Mar 4 2023
Mar 3 2023
Mar 3 2023
Needs final testing before PR
https://github.com/vyos/vyos-1x/compare/current...jestabro:literal
jestabro updated the task description for T5051: Use Literal types to provide op-mode CLI choices and API enums.
jestabro changed the status of T5051: Use Literal types to provide op-mode CLI choices and API enums from Open to In progress.
jestabro triaged T5051: Use Literal types to provide op-mode CLI choices and API enums as Normal priority.
Mar 2 2023
Mar 2 2023
Mar 1 2023
Mar 1 2023
jestabro added a comment to T5040: Generate API GraphQL schema on installation, rather than dynamically.
jestabro triaged T5040: Generate API GraphQL schema on installation, rather than dynamically as Normal priority.
Feb 28 2023
Feb 28 2023
Feb 27 2023
Feb 27 2023
PR using list_interfaces from vyos-utils:
Feb 26 2023
Feb 26 2023
Feb 24 2023
Feb 24 2023
Feb 23 2023
Feb 23 2023
The above repos are suitable for testing: basic tests in vm's and a Protecli device look fine. Note that the vyos-1x repo artificially disables the potential config mode reordering in order to confirm tests of vyos-interface-monitor.:
https://github.com/vyos/vyos-1x/commit/02d874e65262cbd53b413b3eef659b8e7d78bf31
Feb 15 2023
Feb 15 2023
jestabro closed T4991: Restore path level information to compare output, a subtask of T4942: Rewrite vyatta-config-mgmt to Python/XML, as Resolved.
jestabro changed the status of T5006: Http api segfault with concurrent requests from In progress to Needs testing.
@ammmze That PR is merged, so will be in the next rolling. Kindly let me know of any remaining or other issues you see. I'll add autocannon to my common tests; thanks again for that tip.
Feb 14 2023
Feb 14 2023
jestabro changed the status of T5006: Http api segfault with concurrent requests from Open to In progress.
Again, thanks for the detailed reproducer; that made investigation straightforward. This appears to be simply an 'async' issue for FastAPI, the underlying web framework for vyos-http-api. FastAPI is very good at managing red/blue issues automatically, but in this case we need to explicitly annotate the endpoint method with async: an explicit lock does not appear necessary, though I will need to confirm. I'll provide a PR shortly. Thanks again !
@ammmze Thanks for the detailed report; allow me to investigate.
Feb 13 2023
Feb 13 2023
Alfa80 awarded T4991: Restore path level information to compare output a Like token.
Feb 10 2023
Feb 10 2023
Some adjustments made for command output; re-testing for PR.
Feb 9 2023
Feb 9 2023
Running smoketests; PR's to follow:
jestabro added a parent task for T4991: Restore path level information to compare output: T4942: Rewrite vyatta-config-mgmt to Python/XML.
jestabro changed the status of T4991: Restore path level information to compare output from Open to In progress.
Feb 6 2023
Feb 6 2023
Feb 5 2023
Feb 5 2023
PR for alternative completion helper. This provides the same args/output of the Python script, with a speedup of 1--2 orders of magnitude; testing needed.
https://github.com/vyos/vyos-utils/pull/11
Feb 3 2023
Feb 3 2023
Before adopting the approach mentioned above, there was development of an alternative using pyudev within an 'interface-monitor' daemon; the following branches contain (a version of) the rebased code. It would need a few hours of attention to check the logic and add the is_persistent check from vyos-interface-rescan.py; it could use some refactoring as well.
Feb 2 2023
Feb 2 2023
The approach in commit rVYOSONEXee02ca93ec7b of vyos-1x was considered a reasonable workaround for all but a few corner cases. However, the issue pointed out in
Feb 1 2023
Feb 1 2023
Jan 31 2023
Jan 31 2023
PR for Equuleus:
https://github.com/vyos/vyos-build/pull/303
jestabro moved T4970: pin OCaml pcre package to avoid JIT support from Open to Finished on the VyOS 1.4 Sagitta board.
PR for Sagitta:
https://github.com/vyos/vyos-build/pull/301
jestabro added a project to T4970: pin OCaml pcre package to avoid JIT support: VyOS 1.3 Equuleus (1.3.3).
Jan 28 2023
Jan 28 2023
Alfa80 awarded T4962: Fix typo in regex in vyos.config_mgmt compare function a Love token.
Jan 27 2023
Jan 27 2023
jestabro added a comment to T4961: Uncaught configtree error allows ntp migration 1-to-2 to fail silentlly on config.boot.default.
Error reporting: PR's
https://github.com/vyos/vyos-1x/pull/1789
https://github.com/vyos/vyos1x-config/pull/12 (merged)
https://github.com/vyos/libvyosconfig/pull/6 (merged)
Jan 26 2023
Jan 26 2023
jestabro updated the task description for T4961: Uncaught configtree error allows ntp migration 1-to-2 to fail silentlly on config.boot.default.
jestabro lowered the priority of T4961: Uncaught configtree error allows ntp migration 1-to-2 to fail silentlly on config.boot.default from High to Normal.
migration script modified in current; lower task priority to test error reporting from libvyoconfig.
jestabro closed T4957: config-mgmt should not attempt to archive config at boot, a subtask of T4942: Rewrite vyatta-config-mgmt to Python/XML, as Resolved.
Jan 23 2023
Jan 23 2023