Good catch. The proper solution should be:

As soon as someone sets set system ntp allow-clients address 172.16.0.0/12 we act as NTP server for this network,too. It's a bit odd that this node is under system but ... it is as it is.

@syncer we do offer NTP as service (unfortunately it's unter the system tree instead of service.

any updates on this?

looks like a missing check on commit. Will add this case to the new Python script.

Ah, there it is! Thanks!

Implemented in https://github.com/c-po/vyos-1x/commit/b871546cdde982c65e243ec57610edecddb4701b

Even after changing the configuration to

snmp {
    listen-address 172.16.37.241 {
    }
    v3 {
        engineid 0xff42
        user test {
            auth {
                encrypted-key 0x63119b4e19ce4d69c7ad678ffe110047
                type sha
            }
            engineid 0xff42
            mode rw
            privacy {
                encrypted-key 0x63119b4e19ce4d69c7ad678ffe110047
                type aes
            }
        }
    }
}

Commands will be:

@syncer this seems to be the option, plese correct if wrong.

fixed by @higebu in VyOS 1.2.0-rolling+201805171657

... reverting ...

https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s07.html states:

Maybe I got something wrong but my Test indicated by upgrading from VyOS 1.1.7 to 1.2.x worked. the service ssh allow-root config line just vanished and remote login worked like a charm. I always tried to be backwards compatible at least with VyOS 1.1.7.

Proposal for command:

Merged as discussed via slack

It's a general problem with the new Python scripts. Somehow the lib is injured :/ @dmbaturin

Hello @rodge.liu what exactly do you mean by invalid? Does it have no result? I'm currently re-writing this section to the new XML style interface so there could me a slip. A new ISO image is born at this very moment so please retry with the latest version in about 30 minutes.

I just tested the latest vyos-1x package commit 860b229.

Implementation for this task is ready, only awaiting a decission.

Changes can be seen here: https://github.com/c-po/vyos-1x/commits/ssh-rewrite

For IP address or network checking I tried Python ipaddress package. https://github.com/c-po/vyos-1x/blob/current/src/conf-mode/vyos-config-ntp.py#L22

@Watcher7 must this always be added into /etc/strongswan.d/charon_vti.conf?

Looks very good!