Page MenuHomeVyOS Platform

xml: replace inline node definitions duplicating existing include files
In progress, LowPublicFEATURE REQUEST

Description

Several CLI node definitions in interface-definitions/ are written out inline although an identical include file already exists. This duplicates XML and lets the copies drift apart over time.

Inline definitions that are identical to an existing include:

FileNodeExisting include
system_conntrack.xml.in (2x)protocolinclude/firewall/protocol.xml.i
include/accel-ppp/radius-additions.xml.iaccounting-interim-intervalinclude/accel-ppp/radius-accounting-interim-interval.xml.i
include/ospf/protocol-common-config.xml.ino-summaryinclude/ospfv3/no-summary.xml.i

Replace these with the matching #include statements.

The CLI does not change: the generated node.def templates and the preprocessed XML (input for the reference tree cache) are identical before and after.

Details

Version
rolling
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Feature (new functionality)

Event Timeline

c-po changed the task status from Open to In progress.
c-po triaged this task as Low priority.