Page MenuHomeVyOS Platform

VPP: Rewrite the CLI for ACL tcp-flags
Closed, ResolvedPublicENHANCEMENT

Description

Now we have multiple valueless nodes

set vpp acl ip tag-name <txt> rule <u32> tcp-flags ack [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags cwr [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags ecn [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags fin [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags not ack [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags not cwr [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags not ecn [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags not fin [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags not psh [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags not rst [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags not syn [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags not urg [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags psh [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags rst [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags syn [valueless]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags urg [valueless]

Replace all individual valueless flag nodes with a multi-value model:

set vpp acl ip tag-name <txt> rule <u32> tcp-flags is-set <flag_name> [multi]
set vpp acl ip tag-name <txt> rule <u32> tcp-flags is-not-set <flag_name> [multi]

Details

Version
-
Is it a breaking change?
Config syntax change (migratable)
Issue type
Feature (new functionality)